User 서버 request 변경에 따른 수정사항 반영, 댓글 달기 및 조회 API #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Summary
✏️ Describe your changes
User 서버의 커뮤니티 회원 조회가 기존의
RequestBody
->QueryParms
로 변경되면서 List로 받았던userIdList
를String
으로 변경하는 작업이 필요했습니다. List의 각 원소를 ','로 join하여 String으로 만들어 uri를 빌드할 때 추가했고, 코드 리뷰를 통해 알게된onStatus
에서 response의 상태를 확인하여 예외처리를 할 수 있도록 변경했습니다.Server_Community/src/main/java/porori/backend/community/service/UserService.java
Lines 59 to 75 in 372e636
다른 request들도 변경 사항에 맞게 수정하였고, 동일하게
onStatus
도 적용했습니다..!Server_Community/src/main/java/porori/backend/community/service/UserService.java
Lines 27 to 42 in a49e631
게시글 상세보기와 댓글 조회가 하나의 API로 합쳐져 있었는데 response 가독성이 너무 좋지 않았고, 로직 또한 복잡해져서 피드백을 받아 각각을 조회하는 API를 분리했습니다.
📖Review Point